Support wild cards in allowed external redirect hosts#7444
Open
labkey-adam wants to merge 7 commits intodevelopfrom
Open
Support wild cards in allowed external redirect hosts#7444labkey-adam wants to merge 7 commits intodevelopfrom
labkey-adam wants to merge 7 commits intodevelopfrom
Conversation
…alls. Route all redirects through ExceptionUtil.unsafeRedirect().
labkey-klum
reviewed
Feb 24, 2026
| // This wild-card pattern matches the host if 1) they have the same number of dots and 2) the host ends with | ||
| // the portion of the pattern after the wild card. | ||
| int expectedDotCount = StringUtils.countMatches(allowedHost, '.'); | ||
| ret = (dotCount == expectedDotCount && Strings.CI.endsWith(host, allowedHost.substring(2))); |
labkey-klum
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Supporting wild cards in allowed external redirect hosts provides convenience when allowing a large number of subdomains is desired. Also, reconcile redirect for consistency and safety. https://github.com/LabKey/internal-issues/issues/852